[feature] nextTriggerAt 저장과 event/task 삭제 시 리마인드 알림 cancel 처리 #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-dhyun
reviewed
Jan 23, 2026
Collaborator
k-dhyun
left a comment
k-dhyun
left a comment
There was a problem hiding this comment.
전체적으로 코드 중복이 줄어들어서 더 깔끔해진 느낌이에요! 저도 중복있는거 더 있나 확인해보겠습니다!
| //반복일정의 경우 다음 알림에 저장 | ||
| Event target = eventRepository.findById(noti.getTargetId()) | ||
| .orElseThrow(() -> new RestApiException(ErrorCode.EVENT_NOT_FOUND)); | ||
|
|
Collaborator
There was a problem hiding this comment.
task 알림 처러시에 event 관련 에러처리가 나와서 조건처리해야될거 같아요. 추후에 task도 반복처리하게될 경우 반복할일도 다음에 알림에 저장하게끔 미리 만들어둬도 괜찮을거 같아요.
|
|
||
| private final ScheduledNotificationRepository scheduledNotiRepository; | ||
| private final EventRepository eventRepository; | ||
|
|
Collaborator
There was a problem hiding this comment.
createScheduledNotification(Event event)랑 createScheduledNotification(Task task) 두개가 비슷한 코드라 코드중복 제거하고 하나로 합치면 좀 더 좋을거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📎 Issue 번호
closed #193
📄 작업 내용 요약
1. nextTriggerAt 저장
사용자가 반복 일정을 생성하고 알림 on 상태로 생성할 경우,
scheduled_notification(예정된 알림 목록)에 첫 번째 알림만 ACTIVE 상태로 생성되고
해당 알림이 실제로 전송된 후에(COMPLETED) 다음 반복주기의 알림을 새로 생성되도록 만들었습니다.
2. event/task 삭제 시 리마인드 알림 cancel 처리
사용자가 리마인드 알림 ON 상태로 생성한 event 또는 task를 삭제하는 경우,
scheduled_notification에 이미 생성되어 있던 해당 알림을
CANCELED 상태로 변경하도록 처리했습니다.
💬 Review Requirements (선택)